Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc][KubeRay] Update PyTorch Mnist Training doc for KubeRay 1.2.0 #47321

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[Doc][KubeRay] Update PyTorch Mnist Training doc for KubeRay 1.2.0 #47321

merged 1 commit into from
Sep 4, 2024

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

The documentation "Train a PyTorch model on Fashion MNIST with CPUs on Kubernetes" is outdated for KubeRay 1.2.0 release:

  • Ray image changes from ray:2.9.0 to ray:2.34.0 and the CPU resources request must be changed to work. See the related issues and PRs for details.
  • The output of kubectl get pods are wrong. All pods should be prefixed with rayjob-pytorch-mnist-

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness marked this pull request as ready for review August 24, 2024 18:04
@MortalHappiness
Copy link
Member Author

@kevin85421 PTAL

@MortalHappiness
Copy link
Member Author

Doc CI link: https://anyscale-ray--47321.com.readthedocs.build/en/47321/cluster/kubernetes/examples/mnist-training-example.html

@anyscalesam anyscalesam added P2 Important issue, but not time-critical core Issues that should be addressed in Ray Core docs An issue or change related to documentation kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side labels Aug 26, 2024
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Aug 27, 2024
@jjyao jjyao merged commit cefedcf into ray-project:master Sep 4, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Doc][KubeRay] Update PyTorch Mnist Training doc for KubeRay 1.2.0 (r…
91eb426 
…ay-project#47321)

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

Assignees

@kevin85421 kevin85421

Labels
core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side P2 Important issue, but not time-critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MortalHappiness @kevin85421 @jjyao @anyscalesam