[Data] Skip empty JSON files in read_json()
#47378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatram-dev
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
venkatram-dev
force-pushed
the
skip_empty_json_files
branch
from
4fe6fd9
to
430ea5e
Compare
|
Tested the changes in local Before the changeAfter the change |
|
@scottjlee , Please review. |
scottjlee
reviewed
Aug 29, 2024
There was a problem hiding this comment.
could you also add a unit test in test_json.py to test the change in this PR?
you can follow the logic in the reproducible example from the original issue. thanks!
| @@ -101,6 +101,11 @@ def _read_with_python_json(self, buffer: "pyarrow.lib.Buffer"): | |||
|
|
|||
| import pyarrow as pa | |||
|
|
|||
| # Check if the buffer is empty | |||
| if buffer.size == 0: | |||
| yield pa.Table.from_pylist([]) # Yield an empty PyArrow Table | |||
There was a problem hiding this comment.
in the case of an empty file, i think we can simply return out, instead of yielding an empty table. but let's confirm with a unit test.
Signed-off-by: venkatram-dev <[email protected]>
Signed-off-by: venkatram-dev <[email protected]>
venkatram-dev
force-pushed
the
skip_empty_json_files
branch
from
aa159ff
to
8cf0444
Compare
Signed-off-by: venkatram-dev <[email protected]>
@scottjlee , Added Unit test to read from a file path containing both empty file and non empty file. |
scottjlee
changed the title
read_json()
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
## Why are these changes needed? Skip empty files and do not raise json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) ## Related issue number Closes ray-project#47198 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: venkatram-dev <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#47198
Skip empty files and do not raise json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Related issue number
#47198
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.