Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Remove limit on number of tasks launched per scheduling step #47393

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

In each Ray Data scheduling step, Ray Data launches tasks until it can't launch any more. To ensure that the progress bar updates frequently, #33952 made it such that Ray Data can only launch 50 tasks per scheduling step. However, this cause performance issues for large workloads.

This PR fixes the issue by removing the limit on number of tasks launched while still updating the progress bar frequently.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned that this change may cause regression on latency-sensitive jobs.
Because now process_completed_tasks will be called less often.
Not sure how big the impact would be.
Maybe it's fine to merge it first and keep an eye on the release tests.

@bveeramani bveeramani enabled auto-merge (squash) August 29, 2024 16:33
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 29, 2024
@bveeramani bveeramani merged commit db735da into master Aug 29, 2024
5 of 6 checks passed
@bveeramani bveeramani deleted the progress-br branch August 29, 2024 18:03
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 12, 2024
…ay-project#47393)

In each Ray Data scheduling step, Ray Data launches tasks until it can't launch any more. To ensure that the progress bar updates frequently, ray-project#33952 made it such that Ray Data can only launch 50 tasks per scheduling step. However, this cause performance issues for large workloads.

This PR fixes the issue by removing the limit on number of tasks launched while still updating the progress bar frequently.

Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants