Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Revert "[Doc] Add Algolia search to docs" #47487

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Sep 4, 2024

Redo https://github.com/ray-project/ray/pull/47483/files. The previous PR was based on a too old base so it gets merged successfully without re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to block changes that can break it.

Test:

  • CI

@can-anyscale can-anyscale force-pushed the can-algolia branch 2 times, most recently from c20de4a to f1488c0 Compare September 4, 2024 22:43
@can-anyscale can-anyscale marked this pull request as ready for review September 4, 2024 23:31
@can-anyscale can-anyscale requested review from a team as code owners September 4, 2024 23:31
Signed-off-by: can <[email protected]>
@can-anyscale can-anyscale enabled auto-merge (squash) September 5, 2024 00:05
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 5, 2024
@can-anyscale can-anyscale merged commit 3beea70 into master Sep 5, 2024
7 checks passed
@can-anyscale can-anyscale deleted the can-algolia branch September 5, 2024 14:56
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Redo https://github.com/ray-project/ray/pull/47483/files. The previous
PR was based on a too old base so it gets merged successfully without
re-compiling the dependencies

Also allow the dry-run of generating build cache to run on premerge, to
block changes that can break it.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants