Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[observability][export-api] Write actor events #47529

Merged
merged 7 commits into from
Sep 9, 2024
Merged

[observability][export-api] Write actor events #47529

merged 7 commits into from
Sep 9, 2024

Conversation

nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented Sep 6, 2024 •
edited
Loading

Why are these changes needed?

  • Add back code changes from [observability][export-api] Write actor events #47303
  • Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 2 commits September 5, 2024 22:59
add back prev code
624e965 
Signed-off-by: Nikita Vemuri <[email protected]>
print lines on failure
d94725a 
Signed-off-by: Nikita Vemuri <[email protected]>
@nikitavemuri nikitavemuri added the go add ONLY when ready to merge, run all tests label Sep 6, 2024
Nikita Vemuri added 4 commits September 6, 2024 07:44
move test to new files
56db6b2 
Signed-off-by: Nikita Vemuri <[email protected]>
update
9322778 
Signed-off-by: Nikita Vemuri <[email protected]>
update test rule
707249d 
Signed-off-by: Nikita Vemuri <[email protected]>
update
37352be 
Signed-off-by: Nikita Vemuri <[email protected]>
@nikitavemuri nikitavemuri changed the title [WIP] [observability][export-api] Write actor events [observability][export-api] Write actor events Sep 6, 2024
@nikitavemuri
Copy link
Contributor Author

This PR was previously reverted because it was failing DataCaseName-windows://:gcs_actor_manager_test-END. Verified Windows core: cpp tests pass in https://buildkite.com/ray-project/premerge/builds/29115#0191c81d-3a20-4ebf-b6dd-20a5149a1ae0

run tests
13278c5 
Signed-off-by: Nikita Vemuri <[email protected]>
@nikitavemuri
Copy link
Contributor Author

Added empty commit 13278c5 to run base set of premerge tests because two of the Windows tests were stuck waiting for agent

@nikitavemuri nikitavemuri marked this pull request as ready for review September 6, 2024 17:27
@nikitavemuri nikitavemuri requested a review from a team as a code owner September 6, 2024 17:27
rkooo567
rkooo567 reviewed Sep 9, 2024
View reviewed changes
BUILD.bazel
@@ -1637,25 +1637,6 @@ ray_cc_test(
],
)

ray_cc_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a single test rule gcs_export_event_test that includes this and the other GCS export api tests (to avoid a new rule per test)

@can-anyscale can-anyscale merged commit d3c0708 into ray-project:master Sep 9, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
f4aeeb4 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
3945e60 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
3348b8e 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
7c24ae4 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
4bc29b8 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
19e21b0 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
f58fb30 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
d5262ce 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
61ccfe0 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
87a2ecf 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
7d50933 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
6b6853b 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
9d25582 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
98d79ff 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
c6a4dbc 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
6f5e2d4 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
d2feb48 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write actor events (ray-project#47529)
9cf02de 
- Add back code changes from [observability][export-api] Write actor events ray-project#47303
- Separate out actor manager export event test into a separate file so we can skip on windows. Update BUILD rule so all tests in src/ray/gcs/gcs_server/test/export_api are skipped on windows

Signed-off-by: Nikita Vemuri <[email protected]>
Co-authored-by: Nikita Vemuri <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@can-anyscale can-anyscale Awaiting requested review from can-anyscale

Assignees

@rkooo567 rkooo567

@can-anyscale can-anyscale

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitavemuri @rkooo567 @can-anyscale