Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding run quickstart button to ray serve stable diffusion tutorial #47546

Conversation

chris-ray-zhang
Copy link
Contributor

Screenshot 2024-09-06 at 4 47 01 PM

@chris-ray-zhang chris-ray-zhang force-pushed the chris/rayservestablediffusionmodelquickstart branch from 79b15bb to 8b0a282 Compare September 6, 2024 23:48
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is very cool! Just wondering if there is a way we can allow existing customers jumping to that page directly and not to the register page, but not a blocker.

@saihaj saihaj added the go add ONLY when ready to merge, run all tests label Sep 7, 2024
@chris-ray-zhang
Copy link
Contributor Author

Oh this is very cool! Just wondering if there is a way we can allow existing customers jumping to that page directly and not to the register page, but not a blocker.

Hi Gene, do you mean jumping directly into the Anyscale template?

@GeneDer
Copy link
Contributor

GeneDer commented Sep 7, 2024

More or less. Supposedly I already have an account and am logged in, it would be nice to get to that temple page directly. For none anyscale customer I understand this will probably redirect them to the template page after they sign up.

@chris-ray-zhang
Copy link
Contributor Author

More or less. Supposedly I already have an account and am logged in, it would be nice to get to that temple page directly. For none anyscale customer I understand this will probably redirect them to the template page after they sign up.

Yes if you are already logged in, it will drop you directly into the template page. You can try yourself with this example here: https://docs.ray.io/en/latest/data/examples/pytorch_resnet_batch_prediction.html

I've also attached a loom video for your reference
https://www.loom.com/share/7fd8f9a9a8d94885b470faa56e029443

@GeneDer
Copy link
Contributor

GeneDer commented Sep 7, 2024

Oh I see, so I guess once this is merged. The docs page will render the url to /template-preview path? (the one in the PR is going to /register that's why I was wondering in the first place)
image

@chris-ray-zhang
Copy link
Contributor Author

Oh I see, so I guess once this is merged. The docs page will render the url to /template-preview path? (the one in the PR is going to /register that's why I was wondering in the first place) image

Ah i see. great callout. let me check

@chris-ray-zhang
Copy link
Contributor Author

Oh I see, so I guess once this is merged. The docs page will render the url to /template-preview path? (the one in the PR is going to /register that's why I was wondering in the first place) image

Ah i see. great callout. let me check

yes it should automatically redirect with the redirectTo param @saihaj can you pls confirm?

@can-anyscale can-anyscale merged commit d471564 into ray-project:master Sep 8, 2024
6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants