Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Remove unused Serve constants #47593

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[Serve] Remove unused Serve constants #47593

merged 1 commit into from
Sep 11, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Sep 10, 2024

Why are these changes needed?

Went through all the constants in the file and remove the ones that's no longer in use.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Sep 10, 2024
edoakes
edoakes approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edoakes edoakes merged commit 6812c6e into ray-project:master Sep 11, 2024
5 checks passed
@GeneDer GeneDer deleted the remove-unused-constants branch September 11, 2024 16:50
@GeneDer GeneDer self-assigned this Sep 11, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
edca97a 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
c148b12 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
197e784 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
b9265f9 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
ecacd10 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
a88d517 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
9e4a076 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
15132d5 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] Remove unused Serve constants (ray-project#47593)
8f9236c 
Went through all the constants in the file and remove the ones that's no

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@GeneDer GeneDer

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeneDer @edoakes