Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] fix component id logging field #47609

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[Serve] fix component id logging field #47609

merged 1 commit into from
Sep 12, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Sep 11, 2024

Why are these changes needed?

Re: https://github.com/ray-project/ray/pull/46215/files#diff-7cdcb1bc84fb40e59bcec9c12e97178abb61f0cad81c1c3077b4911b68b0416fR71

In the previous PR I had a typo replaced component_id with replica field name. TDD make sure this is captured in the test then fixed the issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Sep 11, 2024
@GeneDer GeneDer self-assigned this Sep 11, 2024
@GeneDer
Copy link
Contributor Author

GeneDer commented Sep 12, 2024

@edoakes this is ready for merge

@edoakes edoakes merged commit b2117e4 into ray-project:master Sep 12, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@GeneDer @ujjawal-khare
[Serve] fix component id logging field (ray-project#47609)
942105d 
Re:
https://github.com/ray-project/ray/pull/46215/files#diff-7cdcb1bc84fb40e59bcec9c12e97178abb61f0cad81c1c3077b4911b68b0416fR71

In the previous PR I had a typo replaced `component_id` with `replica`
field name. TDD make sure this is captured in the test then fixed the
issue.

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@GeneDer GeneDer

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeneDer @edoakes