Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][aDAG] Fix microbenchmark regression adag 2 #47683

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[core][aDAG] Fix microbenchmark regression adag 2 #47683

merged 2 commits into from
Sep 16, 2024

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Sep 16, 2024 •
edited
Loading

Why are these changes needed?

After multi ref PR, we cannot just do await on returned value when it is multi ref output

Related issue number

Closes #47667

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 enabled auto-merge (squash) September 16, 2024 16:42
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 16, 2024
@kevin85421
Copy link
Member

Is this related to #47667? If so, add "closes #47667" in the PR description.

@rkooo567 rkooo567 merged commit 34a59c6 into ray-project:master Sep 16, 2024
6 checks passed
@rkooo567 rkooo567 mentioned this pull request Sep 16, 2024
Closed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 17, 2024
@rkooo567 @simonsays1980
[core][aDAG] Fix microbenchmark regression adag 2 (ray-project#47683)
3929ce6 
After multi ref PR, we cannot just do await on returned value when it is multi ref output
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@rkooo567 @ujjawal-khare
[core][aDAG] Fix microbenchmark regression adag 2 (ray-project#47683)
dbe8f69 
After multi ref PR, we cannot just do await on returned value when it is multi ref output

Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisearch42 ruisearch42 ruisearch42 approved these changes

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

@ruisearch42 ruisearch42

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core][experimental] ADAG microbenchmark fails
3 participants
@rkooo567 @kevin85421 @ruisearch42