-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Simplify and consolidate progress bar outputs #47692
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4db8321
rework outputs
scottjlee bc918f3
Merge branch 'master' into 0916-progbar-emoji
scottjlee 3e3b70d
comments
scottjlee 12d4455
Merge branch 'master' into 0916-progbar-emoji
scottjlee 1969bac
reformat as tabular tuples
scottjlee af218fc
Revert "reformat as tabular tuples"
scottjlee 11ed8f5
revert to verbose op-level progress bar
scottjlee 8f9873d
removing pending emoji
scottjlee 7861e8d
remaining emojis
scottjlee 66f5692
comments
scottjlee 5ef5aa8
format
scottjlee 75a0cd2
format
scottjlee 00c43b0
move actor locality back to progress_str
scottjlee 1c892da
Merge branch 'master' into 0916-progbar-emoji
scottjlee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW @raulchen i still had to leave some
ActorPoolMapOperator
specific logic, in order to add the locality string (checking the attributeif self.op._actor_locality_enabled
which only exists forActorPoolMapOperator
). but we know thatif active or pending
is true, this must be an operator with actors, so i just useassert isinstance(self.op, ActorPoolMapOperator)
check to satisfy type checking. let me know if you prefer another approachThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I think we can still keep the locality info at the end (still reported by
progress_str
), because it's operator-specific