[RLlib] Enhancements for multi-node/multi-GPU training and better EnvRunner error msg. #47705
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
sven1977
added
rllib
simonsays1980
approved these changes
Sep 17, 2024
| @@ -1392,15 +1392,18 @@ def run_rllib_example_script_experiment( | |||
| # Define compute resources used automatically (only using the --num-gpus arg). | |||
| # New stack. | |||
| if config.enable_rl_module_and_learner: | |||
| # Do we have GPUs available in the cluster? | |||
| num_gpus = ray.cluster_resources().get("GPU", 0) | |||
rllib/utils/test_utils.py
Outdated
| if args.num_gpus > 0 and num_gpus < args.num_gpus: | ||
| raise ValueError( | ||
| f"You are running your script with --num-gpus={args.num_gpus}, " | ||
| "but your cluster only has {resources['GPU']} GPUs! Will " |
There was a problem hiding this comment.
Something missing? "Will ... "?
There was a problem hiding this comment.
Fixed. Now, it'll just warn and then run with CPU-based Learners instead.
Signed-off-by: sven1977 <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…Runner error msg. (ray-project#47705) Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for multi-node/multi-GPU training and better EnvRunner error msg.
config.envis None.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.