[Data] Make sure num_gpus provide to Ray Data is appropriately passed to ray.remote call
#47768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntiation for callers providing different arguments sets Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
alexeykudinkin
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
raulchen
approved these changes
Sep 20, 2024
python/ray/data/_internal/execution/operators/task_pool_map_operator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
raulchen
approved these changes
Sep 20, 2024
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
alexeykudinkin
changed the title
num_gpus provide to Ray Data is appropriately passed to ray.remote callnum_gpus provide to Ray Data is appropriately passed to ray.remote call
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Fixed tests Signed-off-by: Alexey Kudinkin <[email protected]>
alexeykudinkin
commented
Sep 27, 2024
| if key in prev_args: | ||
| # NOTE: We only carry over inheritable value in case | ||
| # of it not being provided in the remote args | ||
| if key in prev_args and key not in remote_args: |
There was a problem hiding this comment.
This was incorrectly handling scheduling_strategy
|
@raulchen had to make some more fixes after this change uncovered issues with the test |
raulchen
approved these changes
Sep 27, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ed to `ray.remote` call (ray-project#47768) Addressing ray-project#47767 Addresses: - Fixes `cached_remote_fn` to properly handle different arg-lists - Makes sure we pass static args to `ray.remote` ctor in `TaskPoolMapOperator` --------- Signed-off-by: Alexey Kudinkin <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Addressing #47767
Addresses:
cached_remote_fnto properly handle different arg-listsray.remotector inTaskPoolMapOperatorChecks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.