Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib; docs] Remove old API stack connector docs entirely. #47778

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[RLlib; docs] Remove old API stack connector docs entirely. #47778

merged 1 commit into from
Sep 23, 2024
+0 −284

Conversation

sven1977
Copy link
Contributor

Remove old API stack connector docs entirely.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
ff86f15 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 added rllib RLlib related issues rllib-connectorv2 Connector related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Sep 21, 2024
@sven1977 sven1977 enabled auto-merge (squash) September 22, 2024 09:46
@sven1977 sven1977 removed the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 22, 2024
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 22, 2024
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 22, 2024
simonsays1980
simonsays1980 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 merged commit 9114b1e into ray-project:master Sep 23, 2024
6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib; docs] Remove old API stack connector docs entirely. (ray-proj…
ebe0733 
…ect#47778)

Signed-off-by: ujjawal-khare <[email protected]>
@sven1977 sven1977 deleted the docs_redo_remove_old_connector_docs branch November 3, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-connectorv2 Connector related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980