[RLlib] Cleanup examples folder (vol 30): BC pretraining, then PPO finetuning (new API stack with RLModule checkpoints). #47838
+331
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
simonsays1980
approved these changes
Sep 27, 2024
| best_result = results.get_best_result(metric_key) | ||
| rl_module_checkpoint = ( | ||
| Path(best_result.checkpoint.path) | ||
| / COMPONENT_LEARNER_GROUP |
| | total time (s) | episode_return_mean | num_env_steps_traine | | ||
| | | | d_lifetime | | ||
| |------------------+------------------------|------------------------| | ||
| | 11.4828 | 250.5 | 42394 | |
There was a problem hiding this comment.
Awesome 11 seconds for 250 points. 51 iterations per 11 seconds is pretty fast.
| | total time (s) | episode_return_mean | num_episodes_lifetime | | ||
| | | | | | ||
| +------------------+------------------------+------------------------+ | ||
| | 32.7647 | 450.76 | 406 | |
There was a problem hiding this comment.
Dom we have by case a number how long it takes to train PPO from zero to 450?
There was a problem hiding this comment.
It's probably not much slower, if at all. But I think this is not the main point here (we know PPO is super fast learning CartPole). The main goal here is to show that:
a) you can use simple custom Models w/o having to sub-class algo-specific RLModule classes!! <- this is huge and thanks to the new RLModule API concept.
b) it doesn't tank (catastrophic forgetting) after transfer from BC to PPO :)
sven1977
commented
Sep 27, 2024
| @@ -857,6 +857,7 @@ def setup(self, config: AlgorithmConfig) -> None: | |||
| env_steps_sampled=self.metrics.peek( | |||
| NUM_ENV_STEPS_SAMPLED_LIFETIME, default=0 | |||
| ), | |||
| rl_module_state=rl_module_state, | |||
sven1977
commented
Sep 27, 2024
| @@ -1362,7 +1362,11 @@ def run_rllib_example_script_experiment( | |||
| args.as_test = True | |||
|
|
|||
| # Initialize Ray. | |||
| ray.init(num_cpus=args.num_cpus or None, local_mode=args.local_mode) | |||
| ray.init( | |||
There was a problem hiding this comment.
Added reinit error ignore:
In case one calls this utility function twice in an example script.
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
sven1977
deleted the
cleanup_examples_folder_30_bc_train_ppo_finetune
branch
sven1977
added
rllib
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…netuning (new API stack with RLModule checkpoints). (ray-project#47838) Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder (vol 30): BC pretraining, then PPO finetuning (new API stack with RLModule checkpoints).
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.