Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs][KubeRay] Add YuniKorn Gang scheduling doc #47850

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[Docs][KubeRay] Add YuniKorn Gang scheduling doc #47850

merged 5 commits into from
Oct 10, 2024

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

See the description in the corresponding issue for details.

Related issue number

Closes: #47848

Needs ray-project/kuberay#2411 to be merged and KubeRay v1.2.2 release to work.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness mentioned this pull request Sep 28, 2024
Closed
2 tasks
@MortalHappiness MortalHappiness added kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side docs An issue or change related to documentation labels Sep 28, 2024
@kevin85421 kevin85421 self-assigned this Sep 28, 2024
kevin85421
kevin85421 reviewed Sep 28, 2024
View reviewed changes
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
@MortalHappiness MortalHappiness force-pushed the docs/#47848-yunikorn-gang-scheduling branch from bc8bc66 to a7996b5 Compare September 29, 2024 11:19
@MortalHappiness MortalHappiness mentioned this pull request Oct 4, 2024
Merged
4 tasks
@kevin85421
Copy link
Member

@MortalHappiness Would you mind fixing the CI errors?

@yangwwei would you mind reviewing this doc PR? Thanks!

@MortalHappiness MortalHappiness force-pushed the docs/#47848-yunikorn-gang-scheduling branch from a7996b5 to cd1c965 Compare October 6, 2024 04:45
@MortalHappiness MortalHappiness force-pushed the docs/#47848-yunikorn-gang-scheduling branch from cd1c965 to af4dcd9 Compare October 6, 2024 05:12
@MortalHappiness MortalHappiness force-pushed the docs/#47848-yunikorn-gang-scheduling branch from af4dcd9 to 0963746 Compare October 6, 2024 08:15
@kevin85421
Copy link
Member

I have already pinged the doc team to review the PR.

angelinalg
angelinalg approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits on removing some passive voice. Apologies for introducing any inaccuracies. Please correct accordingly. Let me know if you have any questions.

doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/yunikorn.md Outdated Show resolved Hide resolved
@MortalHappiness MortalHappiness force-pushed the docs/#47848-yunikorn-gang-scheduling branch from 0963746 to 8dcb3d2 Compare October 9, 2024 11:12
kevin85421
kevin85421 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can successfully follow the doc.

image

@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Oct 10, 2024
@jjyao jjyao merged commit 15c25b6 into ray-project:master Oct 10, 2024
6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Docs][KubeRay] Add YuniKorn Gang scheduling doc (ray-project#47850)
39db6b9 
Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@kevin85421 kevin85421 kevin85421 approved these changes

@yangwwei yangwwei yangwwei approved these changes

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@rkooo567 rkooo567 Awaiting requested review from rkooo567

Assignees

@kevin85421 kevin85421

Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KubeRay] Add YuniKorn Gang scheduling doc
5 participants
@MortalHappiness @kevin85421 @yangwwei @angelinalg @jjyao