Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix assertion in Simplex space. #47880

Merged
merged 3 commits into from
Oct 7, 2024
Merged

[RLlib] Fix assertion in Simplex space. #47880

merged 3 commits into from
Oct 7, 2024
+3 −3

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Oct 2, 2024 •
edited
Loading

Why are these changes needed?

The assertion in the Simplex space is not checking the correct shape dimensions when concentration parameters are passed in. This PR fixes this.

Related issue number

Closes #45804

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980
Fixed small bug in 'Simplex' space that was throwing an error when pa…
1b63565 
…ssing in concentration parameters for the Dirichlet.

Signed-off-by: simonsays1980 <[email protected]>
@simonsays1980 simonsays1980 added rllib RLlib related issues rllib-env rllib env related issues labels Oct 2, 2024
@simonsays1980 simonsays1980 marked this pull request as ready for review October 2, 2024 15:44
sven1977
sven1977 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @simonsays1980 !

@sven1977 sven1977 enabled auto-merge (squash) October 2, 2024 19:57
@sven1977 sven1977 changed the title [RLlib] - Fix assertion in Simplex space [RLlib] Fix assertion in Simplex space. Oct 2, 2024
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 2, 2024
@simonsays1980
Fixed test for simplex space.
7cc55e1 
Signed-off-by: simonsays1980 <[email protected]>
@github-actions github-actions bot disabled auto-merge October 3, 2024 15:34
@sven1977 sven1977 merged commit f568674 into ray-project:master Oct 7, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@simonsays1980 @ujjawal-khare
[RLlib] Fix assertion in Simplex space. (ray-project#47880)
0224d7b 
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-env rllib env related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLib] AssertionError using Simplex with default concentration
2 participants
@simonsays1980 @sven1977