[RLlib] New API stack: (Multi)RLModule overhaul vol 01 (some preparatory cleanups). #47884
+48
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
sven1977
commented
Oct 3, 2024
| @@ -685,7 +685,6 @@ def setup(self, config: AlgorithmConfig) -> None: | |||
| ) | |||
| and self.config.input_ != "sampler" | |||
| and self.config.enable_rl_module_and_learner | |||
| and self.config.enable_env_runner_and_connector_v2 | |||
There was a problem hiding this comment.
note: we don 't need these double checks anymore b/c the hybrid stack has been deprecated already (users will get error message in the config.validate() call).
There was a problem hiding this comment.
Yes, let's remove it!
sven1977
commented
Oct 3, 2024
| with self.metrics.log_time((TIMERS, ENV_RUNNER_SAMPLING_TIMER)): | ||
| if self.config.count_steps_by == "agent_steps": | ||
| train_batch, env_runner_results = synchronous_parallel_sample( | ||
| episodes, env_runner_results = synchronous_parallel_sample( |
simonsays1980
approved these changes
Oct 3, 2024
| @@ -685,7 +685,6 @@ def setup(self, config: AlgorithmConfig) -> None: | |||
| ) | |||
| and self.config.input_ != "sampler" | |||
| and self.config.enable_rl_module_and_learner | |||
| and self.config.enable_env_runner_and_connector_v2 | |||
There was a problem hiding this comment.
Yes, let's remove it!
| # this information only needs to be kept in the Learner and not on the | ||
| # EnvRunners anymore. | ||
| if not self.config.enable_env_runner_and_connector_v2: | ||
| policies_to_train = self.config.policies_to_train or set( |
There was a problem hiding this comment.
Don't we need this still in the old stack?
There was a problem hiding this comment.
The code will never get there anymore because users on the new API stack will call add_module and remove_module (instead of add_policy and remove_policy). But you are right, we should error out here directly if the config says otherwise. I'll add these exceptions ...
There was a problem hiding this comment.
Ah, these errors are already there.
Signed-off-by: sven1977 <[email protected]>
…odule_do_over_bc_default_module_01_preparation
Signed-off-by: sven1977 <[email protected]>
…odule_do_over_bc_default_module_01_preparation
sven1977
deleted the
rl_module_do_over_bc_default_module_01_preparation
branch
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ory cleanups). (ray-project#47884) Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API stack: (Multi)RLModule overhaul vol 01 (some preparatory cleanups).
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.