-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state'. #47914
Merged
sven1977
merged 8 commits into
ray-project:master
from
simonsays1980:fix-get-state-of-infinite-lookback-buffer
Oct 10, 2024
Merged
[RLlib] Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state'. #47914
sven1977
merged 8 commits into
ray-project:master
from
simonsays1980:fix-get-state-of-infinite-lookback-buffer
Oct 10, 2024
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or for composite spaces Signed-off-by: simonsays1980 <[email protected]>
simonsays1980
added
bug
Something that is supposed to be working; but isn't
rllib
RLlib related issues
rllib-env
rllib env related issues
labels
Oct 6, 2024
simonsays1980
requested review from
sven1977 and
ArturNiederfahrenhorst
as code owners
October 6, 2024 11:23
… composite space samples if spaces are given. Signed-off-by: simonsays1980 <[email protected]>
… composite space samples if spaces are given. Signed-off-by: simonsays1980 <[email protected]>
sven1977
changed the title
[RLlib] - Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state'
[RLlib] Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state'.
Oct 8, 2024
sven1977
reviewed
Oct 8, 2024
sven1977
reviewed
Oct 8, 2024
Signed-off-by: Sven Mika <[email protected]>
sven1977
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix @simonsays1980 .
Signed-off-by: simonsays1980 <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…'. (ray-project#47914) Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something that is supposed to be working; but isn't
go
add ONLY when ready to merge, run all tests
rllib
RLlib related issues
rllib-env
rllib env related issues
rllib-newstack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When
get_state
is called it tries to turn thespace_struct
into a dictionary by usinggym_space_to_dict
. This errors out for composite spaces because the outer space is not a space but a container (i.e. the sample fo that space). This PR fixes this error, but focusing on thespace
attribute which isa truegymnasium.spaces.Space
in its outer space and rebuild thespace_struct
infrom_state
when existent.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.