Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Cleanup examples folder vol. 25: Remove some old API stack examples. #47970

Merged
merged 3 commits into from
Oct 10, 2024
Merged

[RLlib] Cleanup examples folder vol. 25: Remove some old API stack examples. #47970

merged 3 commits into from
Oct 10, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 10, 2024 •
edited
Loading

Cleanup examples folder vol. 25: Remove some old API stack examples.

  • All the removed script now have direct replacements on the new API stack: Custom metrics, and PPO learning tests on all CPU, multi-CPU, GPU, multi-GPU, single- and multi-agent combinations, w/ or w/o RNN.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
822dc98 
Signed-off-by: sven1977 <[email protected]>
simonsays1980
simonsays1980 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Beautiful! More of these please :)

@sven1977 sven1977 enabled auto-merge (squash) October 10, 2024 12:49
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 10, 2024
@sven1977
fix
e7b54ac 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 requested review from maxpumperla and a team as code owners October 10, 2024 13:05
@sven1977
fix
90e2b9a 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 closed this Oct 10, 2024
@sven1977 sven1977 deleted the cleanup_examples_folder_25_remove_some_old_stack_examples branch October 10, 2024 15:08
@sven1977 sven1977 restored the cleanup_examples_folder_25_remove_some_old_stack_examples branch October 10, 2024 16:12
@sven1977 sven1977 reopened this Oct 10, 2024
@sven1977 sven1977 merged commit 793ea9d into ray-project:master Oct 10, 2024
4 of 5 checks passed
@sven1977 sven1977 deleted the cleanup_examples_folder_25_remove_some_old_stack_examples branch October 10, 2024 16:12
@sven1977 sven1977 added rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack rllib-envrunners Issues around the sampling backend of RLlib tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Oct 10, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
3421c18 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
84cd15d 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
9505189 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
00946b7 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
3111a2f 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
420d3d7 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
ce57aea 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
ca5d29b 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Cleanup examples folder vol. 25: Remove some old API stack ex…
0dcefc0 
…amples. (ray-project#47970)

Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-envrunners Issues around the sampling backend of RLlib rllib-newstack tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980