Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add framework-check to MultiRLModule.add_module(). #47973

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 10, 2024

Add framework-check to MultiRLModule.add_module().

Feedback from a MultiRLModule user:

When adding a new module to an existing MultiRLModule (https://github.com/ray-project/ray/blob/312730e6d3bc5d9bf8e4dcd66f00b411366323e3/rllib/core/rl_module/multi_rl_module.py#L152),
it would be nice to have a check of the framework of the new model, making sure it doesn't conflict with the
frameworks of other modules, and also setting the framework of the MultiRLModule
if the framework is None at that point. The setting of framework is done in
https://github.com/ray-project/ray/blob/312730e6d3bc5d9bf8e4dcd66f00b411366323e3/rllib/core/rl_module/multi_rl_module.py#L74,
but it doesn't cover the case of modules added after setup.

This PR solves the above problem.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clear.

@sven1977 sven1977 enabled auto-merge (squash) October 10, 2024 15:16
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 10, 2024
@sven1977 sven1977 added rllib RLlib related issues rllib-multi-agent An RLlib multi-agent related problem. rllib-models An issue related to RLlib (default or custom) Models. rllib-newstack labels Oct 10, 2024
@sven1977 sven1977 merged commit 3d8ea28 into ray-project:master Oct 10, 2024
5 of 6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-models An issue related to RLlib (default or custom) Models. rllib-multi-agent An RLlib multi-agent related problem. rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants