Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS] introduce new gcs client and refactor actor table #5058

Merged
merged 73 commits into from
Jul 19, 2019

Conversation

micafan
Copy link
Contributor

@micafan micafan commented Jun 28, 2019

What do these changes do?

Refactor the GCS Client, as the proposal suggessted, please ref here.

  1. GcsClientInterface is the base class of GCS client.
  2. AsyncGcsClient inherits the interface of GcsClientInterface(constructor was refactored), and rename to RedisGcsClient.
  3. By new interface, we use XXXAccessor to read and write(also subscribe) from GCS, e.g.: AccessorStateAccessor contains all method that raylet used to read and write actor involved message from GCS.
    We do all the needed changes for each table at raylet side. This time only the ActorTable related was changed(changed to ActorStateAccessor).
  4. The changed files look a lot, but most of the file changes are caused by renames(AsyncGcsClient-->RedisGcsClient).

Related issue number

Linter

  • [ yes] I've run scripts/format.sh to lint the changes in this PR.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1701/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1702/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1706/
Test FAILed.

@raulchen
Copy link
Contributor

Somehow CI stopped running for this PR. Let's check the result here.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15469/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15476/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15477/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15478/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15479/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15475/
Test FAILed.

@raulchen raulchen dismissed pcmoritz’s stale review July 19, 2019 03:26

comments addressed

@raulchen raulchen changed the title [GCS]refactor gcs client [GCS] refactor actor table of gcs client Jul 19, 2019
@raulchen raulchen changed the title [GCS] refactor actor table of gcs client [GCS] introduce new gcs client and refactor actor table Jul 19, 2019
@raulchen raulchen merged commit b5b8c1d into ray-project:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants