-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ID Refactor] Shorten the length of JobID to 4 bytes #5110
[ID Refactor] Shorten the length of JobID to 4 bytes #5110
Conversation
@zhijunfu cc |
Test FAILed. |
Test FAILed. |
@robertnishihara Does this commit make sense to you ? |
Test FAILed. |
Test PASSed. |
@jovany-wang why introduce |
@robertnishihara ray.init() # job_id is 0x00000001
ray.shutdown()
ray.init() # job_id is 0x00000001
ray.shutdown() So, it's not appropriate to use job_id to check whether we have exported the classes and funcs in different sessions. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I left a few comments!
Test FAILed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
@pcmoritz Do the responses make sense to you ? |
Test FAILed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
CI failures seems not related. |
All comments were addressed. Let's merge to unblock others.
What do these changes do?
Some points in this PR:
(1) Shorten the length of
JobID
to 4 bytes.(2) The
job_id
is generated by GCS for uniqueness.(3) Embed
job_id
to driver id. The first 4 bytes of a driver id is the job_id bits, and rest 16bits must be filled with0xFF
.Refer this doc for more details of ID Refactor.
Related issue number
Linter
scripts/format.sh
to lint the changes in this PR.