Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rllib] Eager execution for centralized critic example, fix simple optimizer for multiagent #5683

Merged
merged 6 commits into from
Sep 11, 2019
Merged

[rllib] Eager execution for centralized critic example, fix simple optimizer for multiagent #5683

merged 6 commits into from
Sep 11, 2019

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Sep 10, 2019

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16948/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16963/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16969/
Test PASSed.

@ericl ericl added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 11, 2019
richardliaw
richardliaw reviewed Sep 11, 2019
View reviewed changes
rllib/examples/custom_tf_policy.py
sample_batch,
other_agent_batches=None,
episode=None):
sample_batch["advantages"] = discount(sample_batch["rewards"], 0.99)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should try to fetch gamma from policy config instead right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the example.

richardliaw
richardliaw reviewed Sep 11, 2019
View reviewed changes
rllib/optimizers/sync_samples_optimizer.py Outdated
@@ -29,17 +32,22 @@ def __init__(self,
workers,
num_sgd_iter=1,
train_batch_size=1,
sgd_minibatch_size=0):
sgd_minibatch_size=0,
standardize_fields=[]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None

richardliaw
richardliaw reviewed Sep 11, 2019
View reviewed changes
rllib/optimizers/sync_samples_optimizer.py
PolicyOptimizer.__init__(self, workers)

self.update_weights_timer = TimerStat()
self.standardize_fields = standardize_fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to froenzeset

@ericl ericl merged commit bc6a95d into ray-project:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @AmplabJenkins @richardliaw