Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safari extension #11879

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Update safari extension #11879

merged 9 commits into from
Apr 23, 2024

Conversation

axsuul
Copy link
Contributor

@axsuul axsuul commented Apr 18, 2024

Description

Adds preference to skip browsing iCloud tabs. I was having an issue where an old laptop was still having its iCloud tabs synced, even though that laptop had already been disconnected from iCloud. Furthermore, I only wanted to search local tabs anyways.

CleanShot 2024-04-18 at 16 02 18@2x

When checked, it includes tabs from iCloud devices

CleanShot 2024-04-18 at 15 54 44@2x

When unchecked, it doesn't include tabs from iCloud devices

CleanShot 2024-04-18 at 15 53 40@2x

Fixes #525

Checklist

- Add preference to skip iCloud tabs
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: safari Issues related to the safari extension labels Apr 18, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Apr 18, 2024

Thank you for your contribution! 🎉

🔔 @loris @thomaspaulmann @SKaplanOfficial you might want to have a look.

@pernielsentikaer pernielsentikaer self-assigned this Apr 23, 2024
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 9006edb into raycast:main Apr 23, 2024
6 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/loris/safari

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@axsuul).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@axsuul
Copy link
Contributor Author

axsuul commented Apr 23, 2024

Thanks!

@raycastbot It's been linked 😊

@axsuul
Copy link
Contributor Author

axsuul commented Apr 26, 2024

@pernielsentikaer How do we check if we received the credits for swag? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: safari Issues related to the safari extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Extension Feature Request] Add configuration to exclude tabs from specific devices
3 participants