Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyboard-brightness extension #12011

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Update keyboard-brightness extension #12011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceb782a
Update keyboard-brightness extension
pernielsentikaer Apr 26, 2024
9372303
Update toggle-keyboard-brightness.tsx
pernielsentikaer Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extensions/keyboard-brightness/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Keyboard Brightness Changelog

## [Fix] - 2024-04-26

- Resolved an issue where an error message would appear if the menu bar command was disabled.

## [Improve user feedback and error handling] - 2024-04-10

- Remove adjust-brightness command as it is replaced by increase-brightness and decrease-brightness commands.
Expand Down
12 changes: 8 additions & 4 deletions extensions/keyboard-brightness/src/toggle-keyboard-brightness.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,14 @@ export default async function command() {
await setSystemBrightness(newBrightness!);
await showHUD(`Keyboard Brightness set to ${(newBrightness! * 100).toFixed(0)}%`);

await launchCommand({
name: "menubar-keyboard-brightness",
type: LaunchType.Background,
});
try {
await launchCommand({
name: "menubar-keyboard-brightness",
type: LaunchType.Background,
});
} catch (e) {
() => {};
}
} catch (e) {
console.error(e);
await showHUD("❌ Failed Toggling Keyboard Brightness");
Expand Down