-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Workspace: Add file path information #14888
Conversation
Thank you for the update! 🎉 You can expect an initial review within five business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have some pieces of feedback:
- Isn't it possible to make that a preference, like
Display File Path
, and show it in a different accessory instead of in the tooltip? - Is there a more performant way to find the path of each file? Right now, there can easily be dozens and dozens of calls fired (especially since it's implemented in a recursive way) to display the file path. Also, it'd be probably better to add all of that inside the
useFetch
call to make all of the information display at once.
@thomaslombart Thanks for your review. I have added the |
Can you also take a look at that? Maybe you can turn this hook into a |
It seems that |
Yes, that's why I'm asking to turn |
@thomaslombart, do you mean to change it to this? |
Yes, exactly! I fixed a few things, so this PR is almost ready to merge. |
Published to the Raycast Store: |
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Adds the file path information to the list of accessories.
closes #14874
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder