Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update torr-manager extension #14899

Merged
merged 37 commits into from
Oct 25, 2024
Merged

Conversation

dannius
Copy link
Contributor

@dannius dannius commented Oct 12, 2024

Description

Manager for torrents for https://github.com/YouROK/TorrServer

you have to selfhost it, provide VPS url, login/pass to my extension and then you could do this:

Screencast

Screen.Recording.2024-10-11.at.19.09.30_compressed.mp4

Checklist

- Adjust extension info according to Raycast guidelines
- Add extension icon
- Add jacred-parser command
- Update readme
- Add media player selector
- Refactor code, change api for get list
- Update readme.md
- Configure manager with basic functionality
- Configure manager with basic functionality
- Adjust extension info according to Raycast guidelines
- Adjust extension info according to Raycast guidelines
- Adjust extension info according to Raycast guidelines
- Adjust extension info according to Raycast guidelines
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 12, 2024

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Oct 12, 2024
- Allow search and stream torrents without saving to db
- Add detailed view for searched torrents
- Swap actions, bump eslint
- Swap actions, bump eslint
- Swap actions, bump eslint
- Swap actions, bump eslint
@dannius
Copy link
Contributor Author

dannius commented Oct 14, 2024

Oh, my bad, let me provide you with test credentials to my VPS in case you would like to check it.
Fill free to do mess a bit with torrents, not a problem :D

Screenshot 2024-10-14 at 18 12 22

url: http://45.131.60.99:7443
login: raycast
pass: raycast

  • I checked it with video players IINA and VLC, so i hope you have one of this 2
    ** You can also check the same URL and credentials in your browser if you’re curious

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension and have some feedback ready for you:

  • Some actions are missing icons; could you add those 🙂

torr-manager 2024-10-16 at 10 03 33

  • It keeps failing when I try to list torrents

torr-manager 2024-10-16 at 10 06 00

  • I'm also encountering an error when I try to add one. Do you have any idea why?

torr-manager 2024-10-16 at 10 04 30

  • We don't support illegal torrents, but you can use this to list legal things like Linux distros and other items (so metadata images should contain legal content)

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or on Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Oct 16, 2024
- Fix readme
- Add test connection command
- Add basic icons, fix commands order, move parser link to preferences
- Mark parser url as non-required
- Mark parser url as non-required
- Change default parser to jacket, adjust api calls for parser
- Rename jacred to jackett
- Change default parser to jacket, adjust api calls for parser
- Change default parser to jacket, adjust api calls for parser
- Change default parser to jacket, adjust api calls for parser
- Change default parser to jacket, adjust api calls for parser
@dannius
Copy link
Contributor Author

dannius commented Oct 18, 2024

@pernielsentikaer thanks for the review!
Ready for one more round)

Here is my changes:

  1. first of all i realize that people paste links with '/' at the end, so i handle this case
  2. remove build in "parser" url and make it as preference param (legal perspective), also change parser to most popular https://github.com/Jackett/Jackett?tab=readme-ov-file
  3. adjust response errors to make it human readable
  4. added icons for menu items
  5. Added 'Test connection command' to be sure if user connected (to be able CRUD torrents to server)
image

TESTING:
same credentials for you:
url: http://45.131.60.99:7443/
login: raycast
pass: raycast

New parser api:
parserUrl: http://45.131.60.99:6443/
parserApiKey: 46fvbncusdhxf2p41c72thbnwd7xuxpn

(if u going to check parser please use something popular, i added only 1 tracker to my server).
Probably 'breaking bad' or 'how i met your mother' could be good choice for fast uploading

here is my setup:
image

- Fix handle domain for parser
- Fix handle domain for parser
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the upload command, could you use useForm instead which handles states, validation and errors

- Merge branch \'contributions/merge-1729259439923229000\'
- Pull contributions
- Improve uploading, add useForm
@pernielsentikaer
Copy link
Collaborator

Is this ready for another go?

@dannius
Copy link
Contributor Author

dannius commented Oct 21, 2024

@pernielsentikaer ready! added also some minor changes, looks good now

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put readme-image-*.png in assets (and only one torrent (legal, right) and remove torr-manager-1.png and update the two other images 🙂

- Update posters
- Add selectable categories to jackett search command
- Fix linter errors
- Hide add to server and open in media player commands if unavailable
- Fix linter errors
- Fix linter errors
@dannius
Copy link
Contributor Author

dannius commented Oct 22, 2024

hi @pernielsentikaer i added required fixes and updated all screenshots

For screenshots i used legal torrent indexer 'linuxtracker.org'

  • adjusted description a bit (in search command), just reorder some fields to see 'usefull info' at the top (category, fileSize)
  • also added categories feature, before now categories had been hardcoded movies/tv/series, but now users could search also for some fresh linux images, for example
image

I think i did everything that i had planned, so if it looks good for you we can go forward

Thanks :)

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 900ebb3 into raycast:main Oct 25, 2024
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/dannius/torr-manager

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@dannius).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants