Further Fix for Issue #48 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still rely on the custom mojos to perform the custom golang actions for the project. - Rely on the apache maven-install-plugin to perform the actions to install project artifacts to the local repo. - Rely on the apache maven-deploy-plugin to perform the deployment actions to place the project artifacts in a artifact repository.
|
I forgot to mention that the comparison between the approaches will be to view the local repo after an install, and you should notice that with these changes the project pom is installed in its original form. With the original fix for this issue, no pom was installed, and prior to that, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to show what I was trying to articulate in my earlier comments. Rely on the mature apache plugins for pushing project artifacts to the local repo or remote artifact repos with the maven-install-plugin and maven-deploy-plugin. But, still rely on the mojos within this project to perform the golang actions, and also create the
.mvn-golangthat will be the primary artifact for the project along with the project pom.Changes: