Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADOPTIUM] jdk-17.0.12_7 can't be installed #15

Closed
cimnine opened this issue Sep 4, 2024 · 1 comment
Closed

[ADOPTIUM] jdk-17.0.12_7 can't be installed #15

cimnine opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cimnine
Copy link

cimnine commented Sep 4, 2024

The following pattern does not match any artifacts of the jdk-17.0.12_7 temurin release. Hence, this JDK/JRE can't be downloaded. See https://regexr.com/85his.

private static final Pattern ADOPTGIT_FILENAME_PATTERN = Pattern.compile(
"^OpenJDK([\\da-z]*)-([a-z]+)_([0-9a-z\\-]+)_([0-9a-z]+)_([0-9a-z_]+)_([\\-a-zA-Z0-9]+).(.+)$",
Pattern.CASE_INSENSITIVE);

A quick fix might be to use the following improved pattern. Though I can't say how it behaves with JDK versions other than the specific one I've tested.

^OpenJDK([\da-z]*)-([a-z-]+)_([0-9a-z\-]+)_([0-9a-z-]+)_([0-9a-z_]+)_([\-a-z0-9]+(?:[._\-][0-9][a-z0-9]*)+(?:-metadata)?)\.([a-z0-9.]+)$

A more sustainable approach might be to use the Adoptium API, as I describe in #14.

@raydac raydac self-assigned this Sep 4, 2024
@raydac raydac added the bug Something isn't working label Sep 4, 2024
@raydac
Copy link
Owner

raydac commented Sep 7, 2024

fixed in 1.2.4

@raydac raydac closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants