Avoid libv4l2 pkg-config dependency added by mistake
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Don't forget to add a comment to the code explaining that we don't need the I'm not certain whether that's provided by |
MarijnS95
reviewed
Aug 12, 2024
MarijnS95
reviewed
Aug 12, 2024
vladmovchan
force-pushed
the
limit-pkgconf-to-freebsd
branch
from
5ae4b6e
to
289f607
Compare
MarijnS95
reviewed
Aug 12, 2024
vladmovchan
force-pushed
the
limit-pkgconf-to-freebsd
branch
from
289f607
to
13634b8
Compare
vladmovchan
changed the title
pkg-config use to FreeBSD onlylibv4l2 pkg-config dependency added by mistake
MarijnS95
approved these changes
Aug 12, 2024
MarijnS95
reviewed
Aug 12, 2024
User API header file required to generate bindings in `v4l2-sys` is not part of `libv4l2`. Instead directly check if UAPI header file is present on FreeBSD and extend compiler's include paths. Or guide user towards necessary package if header file is missing.
vladmovchan
force-pushed
the
limit-pkgconf-to-freebsd
branch
from
13634b8
to
6bef448
Compare
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User API header file required to generate bindings in
v4l2-sysis not part oflibv4l2.Instead, directly check if UAPI header file is present on FreeBSD and extend compiler's include paths.
Or guide user towards necessary package if header file is missing.