Override source in the Error impl
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
better-error-impl
branch
from
9e5e8cb
to
b4520b3
Compare
thomaseizinger
changed the title
source and backtrace in the Error implsource in the Error impl
|
This does seem like a compelling reason to raise MSRV.
Why 1.37? AFAICS |
I used |
|
You are right! It got stabilised in 1.30.0: https://doc.rust-lang.org/src/std/error.rs.html#106 |
cuviper
approved these changes
Jun 24, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this may not work with the current 1.12.0 MSRV but I wanted to open this anyway to start a discussion.
Without the
sourceimpl, theErrorimpl is not dramatically useful. All "modern" error handling libraries likeanyhowoperate onsource.New MSRV would be 1.37 with this change.