Add support for resizing Emscripten canvas #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylersaleh
force-pushed
the
emscripten-resize
branch
from
bf9a4f2
to
5154aff
Compare
|
You can see an app with this PR applied at the following address: |
|
@skylersaleh Wow! Amazing! I love that GameBoy emulator! Great work! I'm merging it for now, the implementation looks nice. I need to see how it works with my tools, at this moment I was managing the canvas resizing from html size because every tool had some specific needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was trying to use raylib in an application where I wanted the canvas to be able to be dynamically resized (so that it could cover the entire web page), and I noticed that the support for this was only partially implemented in raylib (and commented out).
So, I went and finished the rest of it and got it working. I hope this is helpful.
Thanks, for making a great library.