Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing defines to CUSTOMIZE_BUILD block #2318

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Conversation

makuto
Copy link
Contributor

@makuto makuto commented Jan 29, 2022

This fixes compilation and linking errors when CUSTOMIZE_BUILD is
ON. Any option wasn't actually applied if it wasn't in this list.

I also added a message which makes it a bit easier to confirm you have
successfully enabled an option.

This fixes compilation and linking errors when CUSTOMIZE_BUILD is
ON. Any option wasn't actually applied if it wasn't in this list.

I also added a message which makes it a bit easier to confirm you have
successfully enabled an option.
@makuto
Copy link
Contributor Author

makuto commented Jan 29, 2022

I copied the options in the same order they are defined in CMakeOptions.txt, which is why the merge is a bit hard to read. Ideally, there would be a way to not require this fragile duplication, but I'm not well-versed enough in CMake to know if that's possible.

@raysan5
Copy link
Owner

raysan5 commented Jan 29, 2022

@makuto Nice! Thanks for the improvement!

@raysan5 raysan5 closed this Jan 29, 2022
@raysan5 raysan5 reopened this Jan 29, 2022
@raysan5 raysan5 merged commit 680cc72 into raysan5:master Jan 29, 2022
@raysan5
Copy link
Owner

raysan5 commented Jan 29, 2022

@makuto Sorry, I click the wrong button and closed it without merging! :P

Reopened and merged!

@makuto
Copy link
Contributor Author

makuto commented Jan 29, 2022

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants