Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GESTURE_DRAG and GESTURE_SWIPE_* issues (mostly) for web #3183

Merged
merged 1 commit into from Jul 19, 2023
Merged

Fix GESTURE_DRAG and GESTURE_SWIPE_* issues (mostly) for web #3183

merged 1 commit into from Jul 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2023

Adds a different check to detect GESTURE_DRAG for PLATFORM_WEB.

Adds a DRAG_TIMEOUT define for the previous check.

Adds GESTURE_HOLD to the check to update the GESTURES.Touch.upPosition.

Changes the default value of FORCE_TO_SWIPE to make it less twitchy for high sensitivity web browsers like Chrome for Android.

Fix #3182.

@raysan5
Copy link
Owner

raysan5 commented Jul 19, 2023

@ubkp Thank you very much for all the amazing work put into improving the gestures module! Actually the review was int the list of future improvements for the library and you mostly did it all by yourself! Thanks!

One detail, trying the example on Windows (with mouse), I notice that HOLD is always issued after just a TAP, shouldn't it take some time to be detected?

@raysan5 raysan5 merged commit 954c601 into raysan5:master Jul 19, 2023
12 checks passed
@ghost
Copy link
Author

ghost commented Jul 19, 2023

@raysan5 I'm really glad I could help. :)

I replied to the question on the #3182 issue, I think it's easier to track there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] GESTURE_DRAG and GESTURE_SWIPE_* issues (mostly) for web.
1 participant