Fix the zooming in the Julia set shader example. #3466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was convinced I had fixed it, but further testing says no! I'll be back with a new PR. I think I understand the issue better after this attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Ever since I added the Julia set shader example (5 years ago!) it had always bugged me that the zoom function was never correct. This PR fixes this, and is also a general tidy-up.
In summary:
COLOR_CYCLESvariable to the shader to allow for cycling of the color palette. This allows for finer details of the fractal to be shown when using a high max iteration number.Issue
Fixes: #3465
Testing
I have tested the code on my Linux machine. I have not tested on glsl100 platforms, or Windows.