Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing PLATFORM_DESKTOP_SDL checks. #3469

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

2Bear
Copy link
Contributor

@2Bear 2Bear commented Oct 26, 2023

There are two missing PLATFORM_DESKTOP_SDL checks in rlgl.h, so that OpenGL ES support in PLATFORM_DESKTOP_SDL is broken.

Add missing PLATFORM* checks can fix that, but a bit dirty.

BTW, consider that more platforms will be supported here, so maybe rlgl.h should be more independent.

@raysan5 raysan5 merged commit 9a687e3 into raysan5:master Oct 26, 2023
@raysan5
Copy link
Owner

raysan5 commented Oct 26, 2023

@2Bear thanks for the review!

BTW, consider that more platforms will be supported here, so maybe rlgl.h should be more independent.

raylib is intended for OpenGL so rlgl should already cover all platforms supporting the technology properly. OpenGL ES support on desktop platforms is not a common use case, they should target OpenGL desktop instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants