BeginScissorMode checks for render texture to avoid using GetWindowScaleDPI #3510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on a window with active
FLAG_WINDOW_HIGHDPI
window flag or on macOS the implementation ofBeginScissorMode
usesGetWindowScaleDPI
to get scaling and uses it on the scissor rect.If using
BeginScissorMode
inside of an openBeginTextureMode
/EndTextureMode
this scaling iswrong as a
RenderTexture
is created with a defined resolution and doesn't share any implicit window dpi scalings.I fixed this by checking if currently a frame buffer is bound to detect the texture mode. If there is a binding the else path of the original implementation will be used to avoid the wrong scaling.