Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowShouldClose(), reset shouldClose flag when window is inited #3518

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

maksut
Copy link
Contributor

@maksut maksut commented Nov 9, 2023

Similar issue with: #3410

Window shouldClose flag does not reset after closing and opening another window. So for the subsequent windows WindowShouldClose always return true.

@maksut
Copy link
Contributor Author

maksut commented Nov 9, 2023

This was a regression with platform split work. In version 4.5.0, desktop platform even reset the flag just after the WindowShouldClose. So it was possible to ignore the flag and continue next frame. But that was not consistent with other platforms. So I hope this little change is fine.

@raysan5 raysan5 merged commit 1b524bb into raysan5:master Nov 9, 2023
@raysan5
Copy link
Owner

raysan5 commented Nov 9, 2023

@maksut thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants