[raudio] Volume, Pan and Pitch getters #3960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeandroSQ I'm afraid I'm not merging this PR, despite following the academic styling of get/set pair. It's up to the user to manage the values they set, so getters shouldn't be needed. |
|
I understand your point, Thank you once more for this amazing work! |
|
@LeandroSQ I could have added that function for some very specific use case but in general I try to avoid adding new functions that can be managed from user side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the current methods to set
Volume,PanandPitchthis pull request implements a getter for the same properties.