Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix some examples #4211

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[examples] Fix some examples #4211

merged 2 commits into from
Aug 6, 2024

Conversation

kai-z99
Copy link
Contributor

@kai-z99 kai-z99 commented Aug 5, 2024

Fix issues where settings values are not displaying on shapes_draw_circle_sector, shapes_draw_rectangle_rounded, and shapes_draw_ring. The issue also notes that the PNGs are rotated 90 deg clockwise compared to the examples which is true, although I believe the samples are accurate and the PNGs are not so I did not change it.

#4208

@CrackedPixel
Copy link
Contributor

It looks like this was removed by @badlydrawnrod in #1470

Not sure why the values were set to NULL. Perhaps by mistake?

This PR seems good and puts it back how the original example worked. I agree with the PNG as well and think the PNG just needs updated

@kai-z99 kai-z99 closed this Aug 5, 2024
@kai-z99 kai-z99 reopened this Aug 5, 2024
@kai-z99
Copy link
Contributor Author

kai-z99 commented Aug 5, 2024

Yeah that odd, It seems that the GUISliderBar() function was changed and took different parameters at that timne which broke it?

@CrackedPixel
Copy link
Contributor

Yeah that odd, It seems that the GUISliderBar() function was changed and took different parameters at that timne which broke it?

I think it was just overlooked in #1470 when updating the example

@raysan5 raysan5 merged commit 97c02b2 into raysan5:master Aug 6, 2024
27 checks passed
@raysan5
Copy link
Owner

raysan5 commented Aug 6, 2024

@kai-z99 Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants