[rModels] Correctly split obj meshes by material #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ented by raylib correctly
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
raysan5
reviewed
Aug 25, 2024
|
@JeffM2501 Added some minor comments, also CodeQL detects some unused variables, maybe those lines could be commented, jsut in case they can be useful in the future. |
|
PR Updated with feedback |
|
@JeffM2501 The redesign looks great to me, thank you very much for working on this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the code that converts tinyOBJ data into raylib meshes and correctly splits the meshes by material so they can be represented by raylib's meshes. This should fix issue #3576
The previous code would just blindly set all meshes to material ID 0.
This is incorrect.
The code in 4.5 would assume there was a material for each mesh, this was also incorrect and would cause a crash.
This version should handle it properly.