Fixed update chainId script #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Github Migration (razor-network#1146) * feat: migrate to github actions * chore: migrate from circle ci * Update develop.yml (razor-network#1148) * Update develop.yml (razor-network#1149) * Update develop.yml * Update develop.yml * Update develop.yml * Fix go mod tidy * Replaced curve instance elliptic.P256() with crypto.S256() (razor-network#1150) * fix: Update Dockerfile with version bumps (razor-network#1152) * chore: hotfix missing workflow * chore: fix dockerfile versions --------- Co-authored-by: Yohan Nelson <[email protected]> Co-authored-by: SkandaBhat <[email protected]> Co-authored-by: Yashk767 <[email protected]>
yohanelly95
approved these changes
Oct 26, 2023
ashish10677
approved these changes
Oct 26, 2023
Yashk767
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
[System os: macOS]
npm run build-allfails onupdate-chainid.shscript with error expecting input to-ioption for stream editorsed.The -i option expects an extension for in-place editing backup. On GNU/Linux, it's optional, but on macOS, it's mandatory.
Fixes: https://linear.app/interstellar-research/issue/RAZ-528
Implementation
Created cases for input to
-iin sed command for macOS and different os.This PR also sync
developbranch withmainbranch by fetching the updated commit frommainbranch.Testing
Ran all the build commands like
npm run build-all,npm run build-noargs,npm run build all-testnetwhich usesupdate-chainId.shscript. All of them ran successfully with correct changes reflected.