Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for job returning results in hex array #1174

Conversation

Yashk767
Copy link
Contributor

@Yashk767 Yashk767 commented Dec 20, 2023

Description

Added support for job like uniswap v2 datasource result which are of type hex conversion of uint256[].

Fixes https://linear.app/interstellar-research/issue/RAZ-634

How Has This Been Tested?

Created a uniswap v2 job which returns value in the form of converted hex array ans ran stakers on local to check whether report correct value or not.

Copy link
Member

@ashish10677 ashish10677 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yashk767 Yashk767 merged commit 3bf2914 into develop Dec 20, 2023
6 checks passed
Yashk767 added a commit that referenced this pull request Jan 17, 2024
#1177)

* fix: conversion of hex to decimal (#1167)

* fix: conversion of hex to decimal

* fix: convertToNumber tests fixed

* feat: added support for job returning results in hex array (#1174)

* feat: added support for jobs returning result in hex array

* feat: added tests for hex array decoding and regex functions

* refactor: fixed golangci-lint errors

* refactor: used hash of url and body as a cache key (#1176)

* refactor: used hash of url and body as cache key instead of just url

* fix: replaced with new cacheKey while reading from cache

* refactor: added tests for different job cases

* refcator: added missing coverage test cases

* refcator: fixed tests

* refactor: fixted tests by replcing binance API with coinbase API

* refactor: job index changed in test name

* fix: conversion of hex to decimal (#1167) (#1169) (#1178)

* fix: conversion of hex to decimal

* fix: convertToNumber tests fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants