Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect state error for shorter epoch length #1192

Merged
merged 10 commits into from
Mar 1, 2024
Merged

fix: incorrect state error for shorter epoch length #1192

merged 10 commits into from
Mar 1, 2024

Conversation

Yashk767
Copy link
Contributor

Description

Transactions were missing state due to delayed state actions consuming more time than expected.

  • This was due to higher values of config parameters bufferPercent and wait.
  • And resetting of jobs/collections cache was part of main voting process which would consume some time.

Fixes
https://linear.app/interstellar-research/issue/RAZ-755
https://linear.app/interstellar-research/issue/RAZ-758

How Has This Been Tested?

Ran a staker on staging with updated config values.

ashish10677
ashish10677 requested changes Feb 27, 2024
View reviewed changes
cmd/config-utils.go Show resolved Hide resolved
cmd/vote.go Outdated Show resolved Hide resolved
@Yashk767
Copy link
Contributor Author

Defined buffer state sleeping time in constants.go, can check this commit 3e8d47a
@ashish10677 @rajkharvar

rajkharvar
rajkharvar previously approved these changes Feb 28, 2024
View reviewed changes
@Yashk767 Yashk767 merged commit 2fd96c8 into develop Mar 1, 2024
6 checks passed
Yashk767 added a commit to Yashk767/razor-go that referenced this pull request Mar 21, 2024
@Yashk767
Revert "fix: incorrect state error for shorter epoch length (razor-ne…
9a3e93a 
…twork#1192)"
@Yashk767 Yashk767 mentioned this pull request Mar 21, 2024
Merged
Yashk767 added a commit that referenced this pull request Mar 22, 2024
@Yashk767
revert: fetching jobs/collections from cache (#1198)
5ae7e15 
* Revert "fix: incorrect state error for shorter epoch length (#1192)"

* Revert "feat: caching jobs and collections (#1183)"

* fix: updated default config value changes considering 5 min epoch

* refactor: recorrected log according to new buffer default 0 value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish10677 ashish10677 ashish10677 approved these changes

@rajkharvar rajkharvar rajkharvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yashk767 @ashish10677 @rajkharvar