Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for APIs responding in json array #1216

Merged

Conversation

Yashk767
Copy link
Contributor

@Yashk767 Yashk767 commented Jun 12, 2024

Description

Added support for APIs which responds in JSON array where we fetch the first element of the JSON array for the data feed.

Fixes #1215

How Has This Been Tested?

  • Added tests with JSON and JSON array API responses covering different parsing scenarios for parseJSONData function.
  • Added jobs for GetDataToCommitFromJob() which respond with different data types JSON array [supported, positive test case] and array of arrays [not supported, negative test case expects an error]
  • Ran vote command with this change and checking returned values in commit state for each job.

@Yashk767 Yashk767 marked this pull request as ready for review June 13, 2024 10:06
ashish10677
ashish10677 previously approved these changes Jun 13, 2024
@Yashk767 Yashk767 force-pushed the yash/raz-857-add-support-for-apis-responding-in-json-array branch from 608eb71 to 3ce857e Compare June 13, 2024 11:54
@Yashk767 Yashk767 merged commit f619148 into develop Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants