Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker: Arrow alignment issue #2256

Open
shreeyansh-singh opened this issue Jun 21, 2024 · 5 comments · May be fixed by #2292
Open

DatePicker: Arrow alignment issue #2256

shreeyansh-singh opened this issue Jun 21, 2024 · 5 comments · May be fixed by #2292

Comments

@shreeyansh-singh
Copy link

Using blade DatePicker selection type as range. When label is not provided, arrow between the fields is not aligned which is not giving a good UX.
Screenshot 2024-06-19 at 4 10 22 PM
@AritraLeo
Copy link
Contributor

I am willing to take up the issue. Plz specify the file location for Date Picker

@snitin315
Copy link
Member

I am willing to take up the issue. Plz specify the file location for Date Picker

@AritraLeo https://github.com/razorpay/blade/blob/master/packages/blade/src/components/DatePicker/DateInput.web.tsx

@k-parihar
Copy link

Hi @snitin315 @AritraLeo
I see no updates on the issue. I think I got the solution. Let me know if I can go ahead and open a PR.

k-parihar added a commit to k-parihar/blade that referenced this issue Jul 2, 2024
@k-parihar
Fix issue razorpay#2256
d72a7ea
@AritraLeo
Copy link
Contributor

Hi @snitin315 @AritraLeo I see no updates on the issue. I think I got the solution. Let me know if I can go ahead and open a PR.

Ya sure I am just doing some open source work here actually.
I failed to come up with an update because of my exams and also I was facing some dependency issues while running the project today. I had contributed some time ago to this repo so may be that is the reason why!

@k-parihar k-parihar linked a pull request Jul 2, 2024 that will close this issue
Open
@k-parihar
Copy link

Hi @snitin315
I had opened PR few days back, can you check and let me know if anything can be improved.

#2292

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(DatePicker): Arrow alignment k-parihar/blade
4 participants
@snitin315 @k-parihar @AritraLeo @shreeyansh-singh