Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DatePicker): Arrow alignment #2292

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(DatePicker): Arrow alignment #2292

wants to merge 4 commits into from

Conversation

k-parihar
Copy link

@k-parihar k-parihar commented Jul 2, 2024 •
edited by saurabhdaware
Loading

Description

Tried fixing the icon position in date range picker when label is absent.

Changes

  1. Added no label margins in iconVerticalMargin
  2. Aligned div to center
  3. Added label-height as margin-top to icon

  • Before
    image

  • After
    image

Additional Information

Fixes #2256

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 14f959f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@k-parihar k-parihar changed the title Fix issue #2256 fix issue #2256 Jul 2, 2024
@k-parihar k-parihar changed the title fix issue #2256 fix: issue #2256 Jul 2, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 2, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14f959f:

Sandbox Source
razorpay/blade: basic Configuration

@k-parihar k-parihar mentioned this pull request Jul 4, 2024
Open
@saurabhdaware saurabhdaware changed the title fix: issue #2256 fix(DatePicker): Arrow alignment Jul 9, 2024
@saurabhdaware saurabhdaware added the Review - L1 First level of review label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar chaitanyadeorukhkar is a code owner

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@anuraghazra anuraghazra Awaiting requested review from anuraghazra anuraghazra is a code owner

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 is a code owner

@saurabhdaware saurabhdaware Awaiting requested review from saurabhdaware saurabhdaware is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@anuraghazra anuraghazra

Labels
Review - L1 First level of review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatePicker: Arrow alignment issue
3 participants
@k-parihar @saurabhdaware @anuraghazra