Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): stop unnecessary event delegation in checkbox #2077

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amandal97
Copy link
Contributor

Description

Event Delegation occurs twice even if the Checkbox is clicked once. This can cause issues while implementing analytics as a single click might infer that the checkbox has been clicked twice. Also, due to this, table multi-select feature not working if we click on the checkbox.

Provided the issue link below for more details.

Changes

Stop propagation from all the child components of the label wrapper except the input element.

Additional Information

#1978

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 3bc8823

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

✅ PR title follows Conventional Commits specification.

Comment on lines +244 to +245
<BaseBox onClick={(e) => e.stopPropagation()}>
<SelectorTitle size={_size} isDisabled={_isDisabled}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have onClick on SelectorTitle itself instead of introducing a BaseBox wrapper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review - L1 First level of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants