Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: django full_clean does not work because of wrong exception is raised #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raducup
Copy link

@raducup raducup commented Aug 31, 2020

Django fields should raise ValidationError in case the value is incorrect, not ValueError.
https://docs.djangoproject.com/en/3.1/ref/forms/validation/

@raducup raducup changed the title fix-django-full_clean-error Bug fix: django full_clean does not work because of wrong exception is raised Oct 24, 2020
@raducup
Copy link
Author

raducup commented Dec 4, 2020

Hello @rbarrois, could you please approve this pool request?

@kennell
Copy link

kennell commented Dec 8, 2020

I woudl also appreciate if this gets merged please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants