-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.rst #119
base: master
Are you sure you want to change the base?
Update README.rst #119
Conversation
Add a line telling which operators are supported in case a '+' part is used in the spec.
@rbarrois - can you please have a look? (automatic workflow does not start as the system considers me a "new" user for this area.) |
@@ -273,6 +273,7 @@ build metadata is equality. | |||
>>> Version('1.0.0+build1') in SimpleSpec('==1.0.0+build2') # Include build in checks | |||
False | |||
|
|||
When using '+' in the spec text only operators '==' and '!=' are supported whilst any variant of lower/greater is not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderStohr I felt that this topic was already addressed in the previous sentence:
Build metadata has no ordering; thus, the only meaningful comparison including build metadata is equality.
Maybe I should add a few examples of comparing versions higher in the README? Or some more details in this example block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt it was not obvious but only implicit by leaving out such examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comparing metadata can be done in principle by using a textual (ascii) or a numeric comparision. Right now its just up to the one that wants to do it - to do it on his own.
"Error: Version 3.4 with arch x64 not found" |
Add a line telling which operators are supported in case a '+' part is used in the spec.